AutoScroll and goto_matching()

Bert Wesarg bert.wesarg at googlemail.com
Thu Dec 27 15:06:40 CET 2007


Thorsten Haude wrote:
> Hi,
> 
> * Bert Wesarg wrote (2007-08-07 22:24):
>> is it intended, that the AutoScroll feature do not work, if the target
>> position of a goto_matching() command is inside the VPadding area?
> 
> Nope, and it does work for a similar search selected, so it might be a
> bug. OTOH, what if the autoscroll would move the first position in the
> autoscroll area? That would make for a jumpy scrolling.
> 
> 
> Thorsten                                        Kristin Hersh: The Thin Man
> 
It looks like I have the following patch in my tree since than:

---

 source/search.c |    3 +++
 1 files changed, 3 insertions(+)

diff --quilt old/source/search.c new/source/search.c
--- old/source/search.c
+++ new/source/search.c
@@ -3463,11 +3463,14 @@ void SelectToMatchingCharacter(WindowInf
     }
     startPos = (matchPos > selStart) ? selStart : matchPos;
     endPos = (matchPos > selStart) ? matchPos : selStart;
 
     /* select the text between the matching characters */
+    XtVaSetValues(window->lastFocus, textNautoShowInsertPos, False, NULL);
     BufSelect(buf, startPos, endPos+1);
+    MakeSelectionVisible(window, window->lastFocus);
+    XtVaSetValues(window->lastFocus, textNautoShowInsertPos, True, NULL);
 }
 
 void GotoMatchingCharacter(WindowInfo *window)
 {
     int selStart, selEnd;

comments?

Bert


More information about the Discuss mailing list