smartIndent.c: remove static

Tony Balinski ajbj at free.fr
Mon Mar 10 20:06:45 CET 2008


Quoting Steve LoBasso <slobasso at yahoo.com>:

> The variables being static was probably written as a speed optimization and
> nothing more.
>
> The current state is fragile but stable. Meaning that it will survive minor
> maintenance but is a potential land mine to any major code manipulation at
> a later date.

I have a feeling this was done to allow initialisation of a whole structure
which, in older C compilers, could only be done with static or global
variables. I know I hit these limitations in the past. Is it just me? Am
I getting that old?

> Removing the static would be safe.

I have no problem with that.


More information about the Develop mailing list