[ nedit-Bugs-1645661 ] Repeated File Open fails

[SourceForge.net]

Bugs item #1645661, was opened at 2007-01-27 00:05
Message generated for change (Settings changed) made by yooden
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=111005&aid=1645661&group_id=11005

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Program
Group: development
>Status: Closed
>Resolution: Fixed
Priority: 9
Private: No
Submitted By: Thorsten Haude (yooden)
Assigned to: Thorsten Haude (yooden)
Summary: Repeated File Open fails

Initial Comment:
The device/inode identifier introduced in SF#1027788 are not initialized properly in CloseWindow() and thus erroneously reports any file opened and closed as still opened. This only shows if nedit.honorSymlinks is set to false.

To repeat:
(unset NEDIT_HOME && source/nedit -xrm "nedit.honorSymlinks: False")
- open any file
- close it
- open it again

(Thanks to Bert Wesarg for pointing this out.)

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-02-01 02:39

Message:
Logged In: NO 

"Other ones" - I really meant your fix for 1608609.



----------------------------------------------------------------------

Comment By: Thorsten Haude (yooden)
Date: 2007-01-31 08:02

Message:
Logged In: YES 
user_id=119143
Originator: YES

I use a waiting period to give others the chance to find bugs in my fixes.
That worked in at least one case, so I think I will keep it up. (And I have
no idea what "other ones" you are talking about.)

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2007-01-31 02:04

Message:
Logged In: NO 

Yooden:

We need you commit your fixes into the CVS, not only this one but also
other ones. 

thanks.



----------------------------------------------------------------------

Comment By: Thorsten Haude (yooden)
Date: 2007-01-29 23:24

Message:
Logged In: YES 
user_id=119143
Originator: YES

File Added: deviceInode.2007-01-29.1.diff

----------------------------------------------------------------------

Comment By: Thorsten Haude (yooden)
Date: 2007-01-29 14:40

Message:
Logged In: YES 
user_id=119143
Originator: YES

I'm not at all sure. I looked over the other stuff yesterday, found some
code segments in serious needs of refactoring (eg.
CreateDocument()/CreateWindow()), immediatley thought about my whining
during the last years and stopped thinking about it. Sorry.

So please, by all means, point out any places where initialisations are
needed. I will have a look at the window->lastModTime positions later
today.

So I think we shouldn't call memset() but initializeWindowInfo(WindowInfo*
window) and think about the problem elsewhere. Refactoring. Sigh.

----------------------------------------------------------------------

Comment By: Andrew Hood (ajhood)
Date: 2007-01-29 12:54

Message:
Logged In: YES 
user_id=36856
Originator: NO

Are you sure this is the only place the device & inode need initialising?
window->lastModTime is set to 0 three times in source/window.c and four
times in source/file.c as part of WindowInfo initialisations/cleanups.

There is a comment in one place that we possibly should do:

memset(window, 0, sizeof(WindowInfo));

----------------------------------------------------------------------

Comment By: Thorsten Haude (yooden)
Date: 2007-01-28 22:59

Message:
Logged In: YES 
user_id=119143
Originator: YES

File Added: deviceInode.2007-01-28.2.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=111005&aid=1645661&group_id=11005